- From: Anne van Kesteren <notifications@github.com>
- Date: Tue, 16 Feb 2021 03:47:19 -0800
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 16 February 2021 11:47:32 UTC
@annevk commented on this pull request.
> @@ -3032,6 +3032,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe
1. Wait until |e|'s [=FetchEvent/wait to respond flag=] is unset.
1. If |e|'s [=FetchEvent/respond-with error flag=] is set, set |handleFetchFailed| to true.
1. Else, set |response| to |e|'s [=FetchEvent/potential response=].
+ 1. If |response| is null, |request|'s [=request/body=] is not null, |request|'s [=request/body=]'s [=Body/source=] is null, and |request|'s [=request/body=] is [=Body/unusable=], set |handleFetchFailed| to true.
The second check here is redundant with checking whether it is unusable. In order for a body to be unusable it has to be non-null.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1563#pullrequestreview-591147367
Received on Tuesday, 16 February 2021 11:47:32 UTC