Re: [whatwg/fetch] Fail request when its streaming body is used in ServiceWorker (#1144)

@annevk commented on this pull request.



> @@ -3834,9 +3834,32 @@ optional <i>CORS-preflight flag</i>, run these steps:
   <p>If <var>request</var>'s <a>service-workers mode</a> is "<code>all</code>", then:
 
   <ol>
+   <li><p>Assert: <var>request</var> 's <a for=request>body</a> is either null or a
+   <a for=/>body</a>.
+
+   <li>
+    <p>Let <var>savedBody</var> be a copy of <var>request</var>'s <a for=request>body</a>.

I think if _originalRequest_ holds a stream, calling `event.request.text()` during the fetch event while not calling `event.repondWith()` should result in a network error still, even if we can make it work due to the additional teeing. It seems nicer to keep enforcing the "read once" rule as much as possible, even though we messed it up for non-stream backed requests in service workers.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1144#discussion_r575134204

Received on Friday, 12 February 2021 10:44:38 UTC