- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 10 Feb 2021 07:50:46 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 10 February 2021 15:51:00 UTC
@domenic approved this pull request. > @@ -2227,11 +2224,8 @@ run these steps: <li><p>Let <var>port</var> be <var>url</var>'s <a for=url>port</a>. - <li><p>If <var>scheme</var> is "<code>ftp</code>" and <var>port</var> is 20 or 21, then - return <b>allowed</b>. - - <li><p>Otherwise, if <var>scheme</var> is a <a>network scheme</a> and - <var>port</var> is a <a>bad port</a>, then return <b>blocked</b>. + <li><p>If <var>scheme</var> is an <a>HTTP(S) scheme</a> and <var>port</var> is a <a>bad port</a>, Optional: now that scheme and port are only referenced once, they don't benefit that much from being factored out into variables (i.e. you could say "if url's scheme is... and url's port is ..."). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1166#pullrequestreview-587758372
Received on Wednesday, 10 February 2021 15:51:00 UTC