Re: [whatwg/fetch] Fail request when its streaming body is used in ServiceWorker (#1144)

@annevk commented on this pull request.



> @@ -3834,9 +3834,32 @@ optional <i>CORS-preflight flag</i>, run these steps:
   <p>If <var>request</var>'s <a>service-workers mode</a> is "<code>all</code>", then:
 
   <ol>
+   <li><p>Assert: <var>request</var> 's <a for=request>body</a> is either null or a
+   <a for=/>body</a>.
+
+   <li>
+    <p>Let <var>savedBody</var> be a copy of <var>request</var>'s <a for=request>body</a>.

Yeah, that might be the way to do it. It's a little bit confusing as the body will be of the request so we it'll need some careful notes. It's also only needed when fetch handed the service worker a stream, right? Because only in that case fetch no longer has a body.

Although I suppose if you `clone()` and then read from the non-cloned request we might still want to fail with a network error even if fetch has a body whose source is a string or some such? Bit unclear to me what's best there.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1144#discussion_r570779547