- From: youennf <notifications@github.com>
- Date: Wed, 15 Dec 2021 02:13:50 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 15 December 2021 10:14:03 UTC
@youennf commented on this pull request.
> + // At this point, videoFrame has been transfered within controller.enqueue call. frameCountTransform cannot mutate it.
+ if (!(++frameCount % 30) && frameCountTransform.onEach30Frame)
+ frameCountTransform.onEach30Frame(frameCount);
+ } catch {
+ videoFrame.close();
+ }
> I think we should mandate that all closable objects have a close operation that is a no-op if the object is already closed (or transferred).
I added a line to explicitly state this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1193#discussion_r769474743
Received on Wednesday, 15 December 2021 10:14:03 UTC