- From: Harald Alvestrand <notifications@github.com>
- Date: Wed, 15 Dec 2021 00:54:46 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 15 December 2021 08:54:59 UTC
@alvestrand commented on this pull request.
> + // At this point, videoFrame has been transfered within controller.enqueue call. frameCountTransform cannot mutate it.
+ if (!(++frameCount % 30) && frameCountTransform.onEach30Frame)
+ frameCountTransform.onEach30Frame(frameCount);
+ } catch {
+ videoFrame.close();
+ }
If we borrow the "transfer" concept from "transferable", the object left behind after the transfer is "neutered"; usually this means all the methods on it check a "neutered" flag before doing anything. (I may have the name wrong.)
I think we should mandate that all closable objects have a close operation that is a no-op if the object is already closed (or transferred).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1193#discussion_r769396040
Received on Wednesday, 15 December 2021 08:54:59 UTC