Re: [w3ctag/design-reviews] "FYI" Review of new window.open() behavior (Issue #691)

Thanks for the review! I agree that it would have been better if this was brought to the TAG earlier. (I am merely the humble Chromium implementer - this change was primarily driven by others.) I do tend to agree with you that `type=popup` leaves more space for changes later. Though... this was discussed. It was proposed [here on the issue](https://github.com/whatwg/html/issues/5872#issuecomment-939106246), and then there was a [discussion on the spec PR](https://github.com/whatwg/html/pull/6530#pullrequestreview-776143934) that resulted in the spec editors both agreeing that a boolean was better. I think the primary rationale was that a boolean was more parallel to the other recent additions to `windowFeatures`, such as `noopener`, `noreferrer`, etc.

I will post a heads-up back to that thread, pointing here, in case people want to take some action!

I think everyone likely agrees with you that a dictionary would have been better than the serialized string for `windowFeatures`, but that ship sailed a very long time ago.

Thanks again for the review!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3ctag/design-reviews/issues/691#issuecomment-993131154