- From: Anne van Kesteren <notifications@github.com>
- Date: Mon, 13 Dec 2021 03:34:03 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1342/review/830115916@github.com>
@annevk commented on this pull request. To clarify, this depends on the other PR that merges everything into "fetch finale", right? > @@ -3824,6 +3824,47 @@ the request. <var>request</var>'s <a for=request>origin</a> to <var>request</var>'s <a for=request>client</a>'s <a for="environment settings object">origin</a>. + <li> + <p>If all of the following conditions are true:</p> + + <ul class=brief> + <li><p><var>request</var>'s <a for=request>destination</a> is not "<code>document</code>" Should this use https://fetch.spec.whatwg.org/#navigation-request instead? The only overlap I can see with mode is for embed/object. Otherwise this would be redundant. > + + <ul class=brief> + <li><p><var>request</var>'s <a for=request>destination</a> is not "<code>document</code>" + + <li><p><var>request</var>'s <a for=request>URL</a>'s <a for=url>scheme</a> is an + <a>HTTP(S) scheme</a> + + <li><p><var>request</var>'s <a for=request>mode</a> is "<code>same-origin</code>", + "<code>cors</code>", or "<code>no-cors</code>" + + <li><p><var>request</var>'s <a for=request>window</a> is not null + + <li><p><var>request</var>'s <a for=request>method</a> is `<code>GET</code>` + + <li><p><var>request</var>'s <a for=request>unsafe-request flag</a> is not set, or + <var>request</var>'s <a for=request>header list</a> is <a for="list">empty</a> ```suggestion <var>request</var>'s <a for=request>header list</a> <a for="list">is empty</a> ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1342#pullrequestreview-830115916
Received on Monday, 13 December 2021 11:34:16 UTC