- From: Mattias Buelens <notifications@github.com>
- Date: Wed, 01 Dec 2021 14:00:06 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/streams/pull/1190/review/820848380@github.com>
@MattiasBuelens commented on this pull request.
> @@ -6850,14 +6900,22 @@ reason.
<div algorithm="create a TransformStream">
To <dfn export for="TransformStream" lt="set up|setting up">set up</dfn> a
newly-[=new|created-via-Web IDL=] {{TransformStream}} |stream| given an algorithm <dfn export
- for="TransformStream/set up"><var>transformAlgorithm</var></dfn> and an optional algorithm <dfn
- export for="TransformStream/set up"><var>flushAlgorithm</var></dfn>, perform the following steps.
+ for="TransformStream/set up"><var>transformAlgorithm</var></dfn>, an optional algorithm <dfn
+ export for="TransformStream/set up"><var>flushAlgorithm</var></dfn>, an optional number <dfn
+ export for="TransformStream/set up"><var>writableHighWaterMark</var></dfn> (default 1), an optional
+ algorithm <dfn export for="TransformStream/set up"><var>writableSizeAlgorithm</var></dfn>, an
+ optional number <dfn export for="TransformStream/set up"><var>readableHighWaterMark</var></dfn>
+ (default 0), and an optional algorithm <dfn export
+ for="TransformStream/set up"><var>readableSizeAlgorithm</var></dfn>, perform the following steps.
Shall I remove the HWM and size algorithm arguments from "set up a `ReadableStream`" and "set up a `WritableStream`" too then?
> (On the other hand, the fact that existing byte-stream-transform specs are calculating the size of all chunks as 1 is a bit unfortunate...)
Hmm, true. Once we have proper byte support for `WritableStream` and `TransformStream`, we'll have "set up with byte reading support" versions for those too, but for now we're in a bit of an awkward position. 😕
Maybe we can already provide such algorithms, even though they won't vend BYOB readers or BYOB writers yet?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1190#discussion_r760603139
Received on Wednesday, 1 December 2021 22:00:19 UTC