Re: [w3c/permissions] Editorial: use permission state concept, not enum values (#285)

@jyasskin requested changes on this pull request.



> +                The <dfn>default permission query algorithm</dfn>, given a to |permissionDesc|'s
+                |permissionDesc:PermissionDescriptor| and a {{PermissionStatus}} |status:PermissionStatus|, runs the following

Something's wrong with the grammar here. Maybe

```suggestion
                The <dfn>default permission query algorithm</dfn>, given a {{PermissionDescriptor}}
                |permissionDesc:PermissionDescriptor| and a {{PermissionStatus}} |status:PermissionStatus|, runs the following
```

?

> @@ -431,25 +434,25 @@ <h3 id="reading-current-states">
           Reading the current permission state
         </h3>
         <p>
-          A |descriptor|'s <dfn class="export" data-local-lt="state">permission state</dfn> for an

You should keep a `<dfn>` here so that people can find the algorithm that produces the state for a given descriptor. It could be `<dfn for="permission descriptor">` if you don't think "permission state" is appropriately defined by an algorithm over descriptors.

>                  steps:
               </p>
               <ol class="algorithm">
-                <li>Set <code>|status|.state</code> to |permissionDesc|'s <a>permission state</a>.
+                <li>
+                  Let |name:PermissionName| be |permissionDesc|.{{PermissionStatus/name}}.
+                </li>
+                <li>Set |status|.{{PermissionStatus/state}} to |permissionDesc|'s the {{PermissionState}} enum value that matches the |name|'s [=permission=] [=permission/state=].

Bad search+replace?

> @@ -369,7 +372,7 @@ <h3>
             <dd>
               <p>
                 Takes no arguments. Updates any other parts of the implementation that need to be
-                kept in sync with changes in the results of <a>permission states</a> or [=powerful
+                kept in sync with changes in the results of permission [=permission/states=] or [=powerful

The fact that you're keeping "permission" here and in several other places seems like a sign that the term should stay "permission state", and not be just "state".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/permissions/pull/285#pullrequestreview-742993652