Re: [whatwg/url] [Editorial] Simplify the ends-in-a-number checker (#633)

@annevk commented on this pull request.



> @@ -681,15 +681,14 @@ steps:
 
  <li><p>Let <var>last</var> be the last <a for=list>item</a> in <var>parts</var>.
 
- <li><p>If parsing <var>last</var> as an <a lt="IPv4 number parser">IPv4 number</a> does not
- return failure, then return true.
-
  <li>
   <p>If <var>last</var> is non-empty and contains only <a>ASCII digits</a>, then return true.

Since this no longer has a note, the `<p>` needs to be on the same line as `<li>`

>   <li>
   <p>If <var>last</var> is non-empty and contains only <a>ASCII digits</a>, then return true.
 
-  <p class=note>This can happen if <var>last</var> starts with "<code>0</code>" so the
-  <a lt="IPv4 number parser">IPv4 number parser</a> tries to parse it as octal, but it is not a
-  valid octal number, as is the case with, for example, "<code>09</code>".
+ <li><p>If parsing <var>last</var> as an <a lt="IPv4 number parser">IPv4 number</a> does not

And here it should be on its own line as the `<li>` has multiple children.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/633#pullrequestreview-742299322