- From: Marcos Cáceres <notifications@github.com>
- Date: Tue, 10 Aug 2021 18:15:06 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 11 August 2021 01:15:19 UTC
@marcoscaceres commented on this pull request. > @@ -763,9 +763,14 @@ <h3> |manifest URL:URL|, and [=URL=] |document URL:URL|: </p> <ol class="algorithm"> - <li>If the type of |json|["start_url"] is not [=string=], return. + <li>Let |docHref:URL| be the result of [=URL Serializer|serializing=] + |document URL| with "exclude fragment" set to true. > Shouldn't we use backticks around true? not in this case... it's calling into an abstract algorithm so it doesn't take code values. > Maybe docHRef? I'll see if I can come up with something less offensive than my current proposal 😂 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/991#discussion_r686422232
Received on Wednesday, 11 August 2021 01:15:19 UTC