Re: [w3c/manifest] Add id member to manifest (#988)

@dmurph commented on this pull request.



> +        application. When the user agent sees a manifest with an |identity|
+        matching that of an already-installed application, it SHOULD be used as
+        a signal that this manifest is a replacement for the already-installed
+        application's manifest, and not a distinct application, even if it is
+        served from a different URL than the one seen previously.
+        </p>
+        <p>
+          The |identity| MAY be used by a service that collects lists of web
+          applications to uniquely identify applications.
+        </p>
+        <p>
+          To <dfn>process the `id` member</dfn>, given [=object=]
+          |json:JSON|, [=ordered map=] |manifest:ordered map|:
+        </p>
+        <ol class="algorithm">
+          <li>Set |manifest|["id"] to |manifest|["start_url"].

Yes - this was a bug I noticed recently w/ Chromium & our parsing, and the spec. if start_url is "", then it just isn't set. I am planning on creating a pull request to set start_url to the document url if it is "" - which I believe is the only time it isn't set?

I guess if it isn't in the json - we would want to catch that case here. Perhaps we have no id though - if there is no start_url, there kind of isn't a webapp, just page metadata. So maybe we say id is undefined if start_url is processed to undefined?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/988#discussion_r685329953