Re: [w3c/manifest] Add id member to manifest (#988)

@marcoscaceres commented on this pull request.



> +          <li>Set |manifest|["id"] to |manifest|["start_url"].
+          </li>
+          <li>If the type of |json|["id"] is not [=string=], return.
+          </li>
+          <li>Let |id:URL| be the result of [=URL Parser|parsing=] |json|["id"]
+          with |manifest|["start_ur"]'s origin as the base URL.
+          </li>
+          <li>If |id| is not same origin as |manifest|["start_url"], return.
+          </li>
+          <li>If |id| is failure, return.

```suggestion
          <li>
          Let |fallbackId:URL| be the result of [=URL Parser|parsing=] |manifest|["start_URL"].
          </li>
          <li>
          Set |manifest|["start_url"] to |fallbackId|. 
          </li>
          <li>
          If the type of |json|["id"] is not [=string=], terminate this algorithm.    
          </li>
          <li>
          Let |id:URL| be the result of [=URL Parser|parsing=] |json|["id"]
          with |manifest|["start_url"]'s origin as the base URL.
          </li>
          <li>
             If |id| is failure, terminate this algorithm.
          </li>
          <li>
             If |id| is not same origin as |manifest|["start_url"], terminate this algorithm.
          </li>
          <li>
            Set |manifest|["start_url"] to |id|. 
          </li>
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/988#pullrequestreview-725020868