- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 04 Aug 2021 10:24:47 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 4 August 2021 17:25:00 UTC
@domenic commented on this pull request. > @@ -4071,35 +4041,30 @@ return <a>this</a>'s <a>shadow-including root</a> if <!-- TODO: domintro --> -The <dfn attribute for=Node>nodeValue</dfn> attribute -must return the following, depending on <a>this</a>: +<p>The <dfn attribute for=Node>nodeValue</dfn> getter steps are to return the following, switching +on <a>this</a>: It's specifically the switches that are strange. E.g. in most programming languages if you do `switch (this) { case X: ... }` that compares `this === X`. But here you seem to be instead doing a `this instanceof X` comparison, which is not how switches usually work. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1004#discussion_r682815606
Received on Wednesday, 4 August 2021 17:25:00 UTC