Re: [whatwg/dom] Revamp the way DOM talks about nodes (#1004)

@domenic commented on this pull request.



> @@ -4071,35 +4041,30 @@ return <a>this</a>'s <a>shadow-including root</a> if
 
 <!-- TODO: domintro -->
 
-The <dfn attribute for=Node>nodeValue</dfn> attribute
-must return the following, depending on <a>this</a>:
+<p>The <dfn attribute for=Node>nodeValue</dfn> getter steps are to return the following, switching
+on <a>this</a>:

The switching is still a bit weird. It might be best to do this as numbered steps so that you can say "this implements Attr / this implements CharacterData"

> @@ -2353,8 +2354,8 @@ of a <var>node</var> into a <var>parent</var> before a <var>child</var>, run the
  <li><p>If <var>child</var> is non-null and its <a for=tree>parent</a> is not <var>parent</var>,
  then <a>throw</a> a "{{NotFoundError!!exception}}" {{DOMException}}.
 
- <li><p>If <var>node</var> is not a {{DocumentFragment}}, {{DocumentType}}, {{Element}}, {{Text}},
- {{ProcessingInstruction}}, or {{Comment}} <a for=/>node</a>, then <a>throw</a> a
+ <li><p>If <var>node</var> is not a {{DocumentFragment}}, {{DocumentType}}, {{Element}}, or
+ {{CharacterData}} <a for=/>node</a>, then <a>throw</a> a

"does not implement"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1004#pullrequestreview-722542486