Re: [whatwg/url] Changes to file URL path normalization (#544)

@rmisev commented on this pull request.



>            <a>normalized Windows drive letter</a>, then <a for=list>append</a> <var>base</var>'s
           <a for=url>path</a>[0] to <var>url</var>'s <a for=url>path</a>.
 
-          <p class=note>This is a (platform-independent) Windows drive letter quirk. Both
-          <var>url</var>'s and <var>base</var>'s <a for=url>host</a> are null under these conditions
-          and therefore not copied.
+          <p class=note>This is a (platform-independent) Windows drive letter quirk.
+          <var>url</var>'s <a for=url>host</a> is null under these conditions.

I think sentence "url’s host is null under these conditions." is meaningless and must be removed. Url's host is null here, because input url string contains no host, but not because these windows drive letter quirk conditions, as we can understand reading it.

>  
-         <li><p>Otherwise, set <var>url</var>'s <a for=url>host</a> to <var>base</var>'s
-         <a for=url>host</a>.
+         <li><p>Set <var>url</var>'s <a for=url>host</a> to <var>base</var>'s <a for=url>host</a>.

Can you swap 1. and 2. steps? I will prefer that host will be set first and then path (i.e. in the order as they appear in the url). This makes sense when implementing parser which serializes as it parses the input.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/544#pullrequestreview-497018455