Re: [w3ctag/design-reviews] hasDroppedEntry in PerformanceObserverCallback (#547)

This was discussed a bit in the WebPerf WG and we heard some concern that `hasBufferOverflow` sounds too close to a [buffer overflow](https://en.wikipedia.org/wiki/Buffer_overflow) so perhaps not the best naming. Regarding `full`, it seems a bit inaccurate since the bool should be true when the buffer became full but also an entry was created after that (hence the buffer lost/dropped an entry). And I think `incomplete` sounds pretty cryptic to me: what's incomplete? Note that the callback will have true anytime in the future after the first callback was true since the bool is answering the question: "does there exist an entry that was not added to the buffer because it was full"?

What about `wasEntryDropped`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3ctag/design-reviews/issues/547#issuecomment-698536511

Received on Thursday, 24 September 2020 19:15:45 UTC