- From: Alice <notifications@github.com>
- Date: Wed, 23 Sep 2020 17:15:15 -0700
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 24 September 2020 00:15:27 UTC
This looks promising, but it's a very complex API and the explainer is quite terse and seems to omit a lot of detail, so it's hard to review the details of the API. For example: > Additionally, the layout bounds of selection and conceptual location of the `EditContext` in the view should be provided by calling `updateLayout`. ```js window.requestAnimationFrame(() => { editContext.updateLayout(editContainer.getBoundingClientRect(), computeSelectionBoundingRect()); }); ``` I'm not quite sure what this is doing. Update the layout of what? Why does it take these two rectangles? In general, it would be helpful at least if the IDL had extensive comments explaining the purpose of each enum, object and method. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/416#issuecomment-698037302
Received on Thursday, 24 September 2020 00:15:27 UTC