Re: [w3c/ServiceWorker] Handle asynchronous modules (top-level await). (#1444)

@hiroshige-g commented on this pull request.



>  
-              1. Invoke [=Reject Job Promise=] with |job| and `TypeError`.
-
-                  Note: This will do nothing if [=Reject Job Promise=] was previously invoked with "{{SecurityError}}" {{DOMException}}.
+      1. If |script| is null or [=Is Async Module=] with |script|'s [=script/record=], |script|'s [=script/base URL=], and « » is true, then:

A random idea: How about checking whether `|evaluationPromise|.\[[PromiseState]] is "pending"` instead of `[=Is Async Module=] ... is true`?

This makes the logic a little simpler (using only `|evaluationPromise|.\[[PromiseState]]`, removing module graph traversal and module inspection), but this is not equivalent from the current condition (e.g. for modules with `await undefined`).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1444#pullrequestreview-494008482