- From: Alice <notifications@github.com>
- Date: Tue, 22 Sep 2020 17:04:26 -0700
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 23 September 2020 00:04:39 UTC
That explainer does what the name implies, thanks so much for your effort there. @cynthia and I are both happy with this. My only feedback would be that it would be nice to see a note explaining why you need to pass `"screen"` to `WakeLock.request()` when it's the only possible value - my guess would be that there is an intent to re-use this API for the future System Wake Lock API, but it would be good to be clear on that. Also, a link out to discussion of that API might also be useful context. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/543#issuecomment-697044566
Received on Wednesday, 23 September 2020 00:04:39 UTC