- From: Mason Freed <notifications@github.com>
- Date: Tue, 08 Sep 2020 13:13:38 -0700
- To: w3c/webcomponents <webcomponents@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 8 September 2020 20:13:50 UTC
> Ok, thanks. I've started doing just that, so I'll check back here once I've had a chance. This week is busy, so possibly next week. In the meantime, if anyone sees any obvious (or not so obvious) issues, do let me know. I implemented this in Chromium, and added some [WPT tests](https://github.com/web-platform-tests/wpt/pull/25402). As far as I can tell, this works pretty well. The tests should include most of the troublesome code samples from this issue thread, but please let me know if I missed a corner case that should be tested. In particular, I think the "intractability" you encountered last time was likely in trying to disallow calls to `attachInternals()` **after** the constructor runs, so that it is only callable from the constructor? This patch/change merely ensures that the constructor is the **first** place that it can be called. Based on the above, I'll put together a spec PR. Sound ok? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/webcomponents/issues/871#issuecomment-689110645
Received on Tuesday, 8 September 2020 20:13:50 UTC