- From: Benjamin Gruenbaum <notifications@github.com>
- Date: Fri, 13 Nov 2020 14:19:22 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 13 November 2020 22:19:35 UTC
Hey @josepharhar generally the implementation looks fine and works well. I've tested a few different cases (calling `.abort` during emit between listeners, once, passive, bubbling etc). I'll try testing it in a big code base to see if I run into more issue :] The only issue I noticed is that passing a signal doesn't seem to work when passing `capture`: <details> ```js { const et = new EventTarget(); const ac = new AbortController(); et.addEventListener('foo', () => console.log('1'), { signal: ac.signal, once: true }); et.addEventListener('foo', () => console.log('2'), { signal: ac.signal }); et.addEventListener('foo', () => console.log('3'), { signal: ac.signal, capture: true }); ac.abort(); et.dispatchEvent(new Event('foo')); // 1 and 2 are not logged, 3 is } ``` </details> <img width="671" alt="Screen Shot 2020-11-14 at 0 13 01" src="https://user-images.githubusercontent.com/1315533/99126487-e8ad4800-260e-11eb-926a-be698b170fe1.png"> -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/issues/911#issuecomment-727063734
Received on Friday, 13 November 2020 22:19:35 UTC