- From: Mattias Buelens <notifications@github.com>
- Date: Tue, 10 Nov 2020 14:48:19 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/streams/pull/1083/review/527670217@github.com>
@MattiasBuelens commented on this pull request. > + 1. Let |startAlgorithm| be the following steps: + 1. Set |iteratorRecord| to ? [$GetIterator$](|asyncIterable|, async). + 1. Let |pullAlgorithm| be the following steps: + 1. Let |nextResult| be [$IteratorNext$](|iteratorRecord|). + 1. If |nextResult| is an abrupt completion, return [=a promise rejected with=] + |nextResult|.\[[Value]]. + 1. Let |nextPromise| be [=a promise resolved with=] |nextResult|.\[[Value]]. + 1. Return the result of [=reacting=] to |nextPromise| with the following fulfillment steps, + given the argument |iterResult|: + 1. If [$Type$](|iterResult|) is not Object, throw a {{TypeError}}. + 1. Let |done| be ? [$IteratorComplete$](|iterResult|). + 1. If |done| is true: + 1. Perform ! [$ReadableStreamDefaultControllerClose$](stream.[=ReadableStream/[[controller]]=]). + 1. Otherwise: + 1. Let |value| be ? [$IteratorValue$](|iterResult|). + 1. Perform ! [$ReadableStreamDefaultControllerEnqueue$](stream.[=ReadableStream/[[controller]]=], Ah, that reminds me: there's currently no way to change the queuing strategy. 😅 Do we want `ReadableStream.from(asyncIterable, queuingStrategy = {})`? That might conflict with a [possible future extension](https://github.com/whatwg/streams/issues/1018#issuecomment-573450716) to pass `{ type: 'bytes' }` to create a readable byte stream. However, we could also introduce `ReadableStream.fromBytes(asyncIterable, queuingStrategy)` for that, [as suggested by Jake](https://github.com/whatwg/streams/issues/1018#issuecomment-587350179). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1083#discussion_r520923403
Received on Tuesday, 10 November 2020 22:48:33 UTC