- From: Andreu Botella <notifications@github.com>
- Date: Mon, 02 Nov 2020 04:47:06 -0800
- To: whatwg/encoding <encoding@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/encoding/pull/246/review/521595064@github.com>
@andreubotella approved this pull request.
LGTM
>
<ol>
<li>
<p>While true:
<ol>
- <li><p>Let <var>result</var> be the result of <a>processing</a> the result of <a>reading</a> from
- <var>input</var> for <var>encoderDecoder</var>, <var>input</var>, <var>output</var>, and
- <var>mode</var>.
+ <li><p>Let <var>result</var> be the result of <a>process an item</a> with the result of
```suggestion
<li><p>Let <var>result</var> be the result of <a>processing an item</a> with the result of
```
> @@ -1023,8 +1020,9 @@ given an optional I/O queue of scalar values <var>output</var> (default « »),
-->
<ol>
- <li><p>Let <var>potentialError</var> be the result of <a>running</a> an instance of <a>UTF-8</a>'s
- <a for=/>decoder</a> with <var>ioQueue</var>, <var>output</var>, and "<code>fatal</code>".
+ <li><p>Let <var>potentialError</var> be the result of <a>process a queue</a> with an instance of
```suggestion
<li><p>Let <var>potentialError</var> be the result of <a>processing a queue</a> with an instance of
```
> @@ -1138,8 +1136,8 @@ is safe as it never triggers <a>errors</a>. [[HTML]]
these steps:
<ol>
- <li><p>Let <var>potentialError</var> be the result of <a>running</a> <var>encoder</var> with
- <var>ioQueue</var>, <var>output</var>, and "<code>fatal</code>".
+ <li><p>Let <var>potentialError</var> be the result of <a>process a queue</a> with
```suggestion
<li><p>Let <var>potentialError</var> be the result of <a>processing a queue</a> with
```
> @@ -1460,7 +1458,7 @@ method steps are:
<p>Otherwise:
<ol>
- <li><p>Let <var>result</var> be the result of <a>processing</a> <var>item</var> for
+ <li><p>Let <var>result</var> be the result of <a>process an item</a> with <var>item</var>,
```suggestion
<li><p>Let <var>result</var> be the result of <a>processing an item</a> with <var>item</var>,
```
> @@ -1549,16 +1547,17 @@ constructor steps are to do nothing.
<li><p>Let <var>item</var> be the result of
<a>reading</a> from <var>input</var>.
- <li><p>Let <var>result</var> be the result of <a>processing</a> <var>item</var> for an instance
- of the <a>UTF-8 encoder</a>, <var>input</var>, <var>output</var>, and "<code>fatal</code>".
+ <li><p>Let <var>result</var> be the result of <a>process an item</a> with <var>item</var>, an
```suggestion
<li><p>Let <var>result</var> be the result of <a>processing an item</a> with <var>item</var>, an
```
> @@ -1791,7 +1790,7 @@ constructor steps are:
<li><p>Return.
</ol>
- <li><p>Let <var>result</var> be the result of <a>processing</a> <var>item</var> for
+ <li><p>Let <var>result</var> be the result of <a>process an item</a> with <var>item</var>,
```suggestion
<li><p>Let <var>result</var> be the result of <a>processing an item</a> with <var>item</var>,
```
> @@ -1808,8 +1807,8 @@ steps:
<li><p>Let <var>output</var> be the <a for=/>I/O queue</a> of scalar values
« <a>end-of-queue</a> ».
- <li><p>Let <var>result</var> be the result of <a>processing</a> <a>end-of-queue</a> for
- <var>decoder</var>'s <a for=TextDecoderCommon>decoder</a> and <var>decoder</var>'s
+ <li><p>Let <var>result</var> be the result of <a>process an item</a> with <a>end-of-queue</a>,
```suggestion
<li><p>Let <var>result</var> be the result of <a>processing an item</a> with <a>end-of-queue</a>,
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/encoding/pull/246#pullrequestreview-521595064
Received on Monday, 2 November 2020 12:47:20 UTC