- From: Rossen Atanassov <notifications@github.com>
- Date: Wed, 27 May 2020 16:14:53 -0700
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 27 May 2020 23:15:05 UTC
Also from the same virtual face-to-face review. My main concern with the proposal is somewhat captured with [issue 150](https://github.com/WICG/display-locking/issues/150). The `beforematch` event opens the door for re-entrant code introducing easy to achieve circularity. The `beforematch` event fires >> the event handler removes the target DOM element >> another event handler handles the remove and adds it back to DOM >> etc. I appreciate that you're upfront listing the issues in your explainer however I didn't see good mitigation besides some ideas around scrolling specific logic. Can you provide more details as to how do you intend to stabilize this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/511#issuecomment-634992651
Received on Wednesday, 27 May 2020 23:15:05 UTC