- From: Kagami Sascha Rosylight <notifications@github.com>
- Date: Sat, 23 May 2020 10:48:24 -0700
- To: w3c/editing <editing@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/editing/pull/251/review/417294651@github.com>
@saschanaz requested changes on this pull request.
> };
</script>
- <script src='https://www.w3.org/Tools/respec/respec-w3c-common' class='remove'></script>
+ <script src='https://www.w3.org/Tools/respec/respec-w3c' class='remove'></script>
```suggestion
<script src='https://www.w3.org/Tools/respec/respec-w3c' class='remove'></script>
```
> + <li><code>formatindent</code></li>
+ <li><code>inserthorizontalrule</code></li>
+ <li><code>insertorderedlist</code></li>
+ <li><code>insertunorderedlist</code></li>
+ <li><code>formatitalic</code></li>
+ <li><code>formatoutdent</code></li>
+ <li><code>formatremove</code></li>
+ <li><code>formatstrikethrough</code></li>
+ <li><code>formatsubscript</code></li>
+ <li><code>formatsuperscript</code></li>
+ <li><code>formatunderline</code></li>
+ </ul>
+ </p>
+ <p class="issue" title="missing fontSize and insertImage">
+ fontSize / insertImage is missing from beforeInput. Why? It seems that it should be listed to create a more complete set.
+ <a href="https://github.com/w3c/editing/issues/249">Issue 249</a>
This should reflect the discussion result. Maybe just a note that those are missing.
> + <code>contenteditabledisabled</code> Allowed Token Shortcuts.
+ </h3>
+ <p>
+ The following tokens are also supported by the <code>contenteditabledisabled</code> attribute and serve as shorthands for specifying a set of tokens from contenteditabledisabled Allowed Tokens:
+ </p>
+ <p>
+ <ul>
+ <li><code>formatjustify</code>: combines <code>formatjustifycenter</code>, <code>formatjustifyfull</code>, <code>formatjustifyleft</code>, and <code>formatjustifyright</code>.</li>
+ <li><code>formatfont</code>: combines <code>formatfontname</code>, <code>formatfontsize</code>, and <code>formatfontcolor</code></li>
+ <li><code>formatdent</code>: combines <code>formatindent</code> and <code>formatoutdent</code></li>
+ <li><code>insertlist</code>: combines <code>insertorderedlist</code> and <code>insertunorderedlist</code></li>
+ <li><code>formatscript</code>: combines <code>formatsubscript</code> and <code>formatsuperscript</code></li>
+ </ul>
+ </p>
+ <p class="note">
+ Note that this specification does not have a shortcut to disable all editing UI. Authors should consider using a <code>textarea</code> or <code>contenteditable="plaintext-only"</code> for this purpose.
I think `plaintext-only` shouldn't be recommended as it's currently removed from the spec.
> + [Exposed=Window]
+ interface ElementContentEditable {
```suggestion
partial interface mixin ElementContentEditable {
```
> + The following tokens are also supported by the <code>contenteditabledisabled</code> attribute and serve as shorthands for specifying a set of tokens from contenteditabledisabled Allowed Tokens:
+ </p>
+ <p>
+ <ul>
+ <li><code>formatjustify</code>: combines <code>formatjustifycenter</code>, <code>formatjustifyfull</code>, <code>formatjustifyleft</code>, and <code>formatjustifyright</code>.</li>
+ <li><code>formatfont</code>: combines <code>formatfontname</code>, <code>formatfontsize</code>, and <code>formatfontcolor</code></li>
+ <li><code>formatdent</code>: combines <code>formatindent</code> and <code>formatoutdent</code></li>
+ <li><code>insertlist</code>: combines <code>insertorderedlist</code> and <code>insertunorderedlist</code></li>
+ <li><code>formatscript</code>: combines <code>formatsubscript</code> and <code>formatsuperscript</code></li>
+ </ul>
+ </p>
+ <p class="note">
+ Note that this specification does not have a shortcut to disable all editing UI. Authors should consider using a <code>textarea</code> or <code>contenteditable="plaintext-only"</code> for this purpose.
+ </p>
+ </section>
+ <section id="element-contenteditable-mixin">
<h2>Extensions to the <dfn>ElementContentEditable</dfn> mixin</h2>
```suggestion
<h2>Extensions to the {{ElementContentEditable}} mixin</h2>
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/editing/pull/251#pullrequestreview-417294651
Received on Saturday, 23 May 2020 17:48:37 UTC