Re: [whatwg/url] Editorial: make everything use percent-encode sets (#518)

@domenic commented on this pull request.

I'd like to get whatwg-url fully aligned with these changed sections if possible. (Note that it has a `application/x-www-form-urlencoded` serializer/parser in https://github.com/jsdom/whatwg-url/blob/master/src/urlencoded.js.)

> @@ -3174,18 +3166,13 @@ console.log(url.search);                // "?a=~&b=%7E"
 console.log(url.searchParams.get('a')); // "~"
 console.log(url.searchParams.get('b')); // "~"</code></pre>
 
- <p>{{URLSearchParams}} objects will percent-encode: <a>C0 controls</a>, U+0021 (!) to
- U+0029 RIGHT PARENTHESIS, inclusive, U+002B (+), U+002C (,), U+002F (/), U+003A (:) to U+0040 (@),
- inclusive, U+005B ([) to U+005E (^), inclusive, U+0060 (`), and anything greater than U+007A (z).
- And will encode U+0020 SPACE as U+002B (+).
- <!-- From https://url.spec.whatwg.org/#concept-urlencoded-byte-serializer, inverted.
-      Do not change this without double checking URLENCODED-UNITS -->
-
- <p>Ignoring encodings (use <a>UTF-8</a>), {{URL/search}} will percent-encode U+0000 NULL to
- U+0020 SPACE, inclusive, U+0022 ("), U+0023 (#), U+0027 (') varying on <a>is special</a>,
- U+003C (&lt;), U+003E (>), and anything greater than U+007E (~).
- <!-- From https://url.spec.whatwg.org/#query-state.
-      Do not change this without double checking QUERY-UNITS -->
+ <p>{{URLSearchParams}} objects will percent-encode anything in the
+ <a><code>application/x-www-form-urlencoded</code> percent-encode set</a>. And will encode

```suggestion
 <a><code>application/x-www-form-urlencoded</code> percent-encode set</a>, and will encode
```

>  
-<p>To <dfn for="code point" id=utf-8-percent-encode>UTF-8 percent-encode</dfn> a
-<a for=/>code point</a> <var>codePoint</var> using a <var>percentEncodeSet</var>, run these steps:
+<p class=note>The <a>application/x-www-form-urlencoded percent-encode set</a> contains all code

```suggestion
<p class=note>The <a><code>application/x-www-form-urlencoded</code> percent-encode set</a> contains all code
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/518#pullrequestreview-411879321

Received on Thursday, 14 May 2020 14:52:21 UTC