- From: Rimas Misevičius <notifications@github.com>
- Date: Thu, 14 May 2020 07:02:54 -0700
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 14 May 2020 14:03:08 UTC
@rmisev commented on this pull request. LGTM > +<a for=string>percent-encode after encoding</a> with <a for=/>UTF-8</a>, <var>input</var>, and +<var>percentEncodeSet</var>. ```suggestion <a for=string>percent-encode after encoding</a> with <a for=/>UTF-8</a>, <var>input</var>, <var>percentEncodeSet</var>, and false. ``` It seems you omitted `spaceAsPlus` value. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/url/pull/518#pullrequestreview-411833996
Received on Thursday, 14 May 2020 14:03:08 UTC