- From: Domenic Denicola <notifications@github.com>
- Date: Tue, 12 May 2020 07:03:24 -0700
- To: whatwg/encoding <encoding@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 12 May 2020 14:04:20 UTC
@domenic commented on this pull request. > <ol> - <li><p>If <a for=TextDecoder>do not flush</a> is false, set <a for=TextDecoder>decoder</a> - to a new <a for=TextDecoderCommon>encoding</a>'s <a for=/>decoder</a>, - <a for=TextDecoder>stream</a> to a new <a for=/>stream</a>, and - <a for=TextDecoderCommon>BOM seen</a> to false. + <li><p>If <a>this</a>'s <a for=TextDecoder>do not flush</a> is false, then set <a>this</a>'s + <a for=TextDecoder>decoder</a> to a new <a for=TextDecoderCommon>encoding</a>'s You're right, that wouldn't work. Instead this should match the `new TextDecoderStream` step 6: "Set this’s decoder to a new decoder for this’s encoding" -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/encoding/pull/175#discussion_r423759158
Received on Tuesday, 12 May 2020 14:04:20 UTC