- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 11 May 2020 10:22:20 -0700
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 11 May 2020 17:22:33 UTC
@domenic approved this pull request.
LGTM, thanks for validating with whatwg-url.
>
<ol>
- <li><p>Set <var>url</var>'s <a for=url>username</a> to
- <var>base</var>'s <a for=url>username</a>,
- <var>url</var>'s <a for=url>password</a> to
- <var>base</var>'s <a for=url>password</a>,
- <var>url</var>'s <a for=url>host</a> to
- <var>base</var>'s <a for=url>host</a>,
- <var>url</var>'s <a for=url>port</a> to
- <var>base</var>'s <a for=url>port</a>,
- <var>url</var>'s <a for=url>path</a> to a <a for=list>clone</a> of
- <var>base</var>'s <a for=url>path</a>, and then <a for=list>remove</a>
- <var>url</var>'s <a for=url>path</a>'s last item, if any.
+ <li><p>Set <var>url</var>'s <a for=url>query</a> to null.
+
+ <li><p><a for=list>Remove</a> <var>url</var>'s <a for=url>path</a>'s last item, if any.
<li><p>Set <var>state</var> to <a>path state</a> and decrease <var>pointer</var> by 1.
Might want to split this into two steps while you're here.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/509#pullrequestreview-409374588
Received on Monday, 11 May 2020 17:22:33 UTC