- From: Henri Sivonen <notifications@github.com>
- Date: Wed, 06 May 2020 06:22:36 -0700
- To: whatwg/encoding <encoding@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 6 May 2020 13:22:48 UTC
@hsivonen commented on this pull request.
> @@ -36,7 +30,7 @@ def get_name(cp):
elif cp >= 0xAC00 and cp <= 0xD7A3:
#return "<Hangul Syllable>"
i = cp - 0xAC00
- s = jamo[0][i/28/21] + jamo[1][i/28%21] + jamo[2][i%28]
+ s = jamo[0][int(i/28/21)] + jamo[1][int(i/28%21)] + jamo[2][i%28]
Please use the `//` integer division operator instead of using `int()` afterwards.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/encoding/pull/210#pullrequestreview-406604810
Received on Wednesday, 6 May 2020 13:22:48 UTC