Re: [whatwg/url] Fix validity for opaque hosts (#494)

@domenic commented on this pull request.

Only editorial review; I haven't checked that this does the appropriate thing normatively.

> @@ -457,8 +457,9 @@ up to three <a>ASCII digits</a> per sequence, each representing a decimal number
 
      XXX should we define the format inline instead just like STD 66? -->
 
-<p>A <dfn export>valid opaque-host string</dfn> must be one or more <a>URL units</a> or: U+005B ([),
-followed by a <a>valid IPv6-address string</a>, followed by U+005D (]).
+<p>A <dfn export>valid opaque-host string</dfn> must be one or more <a>URL units</a>, excluding

I think this would be clearer as a bulleted list (one bullet for each branch of the or)

> @@ -787,9 +788,15 @@ then runs these steps:
 <var>input</var>, and then runs these steps:
 
 <ol>
- <li><p>If <var>input</var> contains a <a>forbidden host code point</a> excluding U+0025 (%),
+ <li><p>If <var>input</var> contains a <a>forbidden host code point</a>, excluding U+0025 (%),

IMO this comma addition slightly decreases readability.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/494#pullrequestreview-405896789