Re: [whatwg/url] IPv4 parser cleanup (#493)

It's not clear to me why the validationError variable exists in the IPv4 parser algorithm. It seems like the net effect is delaying the validation error until later, and "hiding" multiple validation errors behind a single validation error. Would it be bad to just report the validation errors when they occur, in steps 3.1 and 6.4?

Another issue: step 6.2/6.3 assumes that the tuple will be of the form (failure, validationError) in the case of failure. But the IPv4 number parser algorithm step 6 just returns raw "failure".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/493#issuecomment-624085623