- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 04 May 2020 06:26:45 -0700
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 4 May 2020 13:26:58 UTC
@domenic commented on this pull request. I couldn't really tell how this impacts the algorithm since there were so many editorial changes, so I just reviewed the definition parts. > -<p>Within a string-based parser algorithm that uses a <var>pointer</var> variable, -<dfn>remaining</dfn> references the substring after <var>pointer</var> in the string -being processed. +<p>When a <a>pointer</a> is defined, <dfn>c</dfn> references the <a for=/>code point</a> What does "defined" mean? My first guess was "not -1", but reading the rest of the paragraph that doesn't seem right... Maybe this is trying to say something like "each pointer has a c, which is a reference to the..."? > <p class=example id=example-12672b6a>If "<code>mailto:username@example</code>" is a <a>string</a> -being processed and <var>pointer</var> points to @, <a>c</a> is U+0040 (@) and <a>remaining</a> is +being processed and <a>pointer</a> points to @, <a>c</a> is U+0040 (@) and <a>remaining</a> is "pointer points to" seems a bit strange; should it be "a pointer" or "the pointer"? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/url/pull/488#pullrequestreview-404981467
Received on Monday, 4 May 2020 13:26:58 UTC