- From: Alice <notifications@github.com>
- Date: Sun, 29 Mar 2020 21:00:43 -0700
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 30 March 2020 04:00:57 UTC
Oof, so sorry I put this off so long, although I did chat with Matt about my comments in person before now, at least. In short, using `Navigator` to set a badge _which is scoped to a single document_ seems odd to me. I am happy with `Navigator.setAppBadge()`, and it seems like `Navigator.setClientBadge()` was intended to keep the document-based API as close as possible to the app-based API, short of having them be the same API which I believe was @hober and @marcoscaceres' preference. However, I still believe the use cases for these two situations look different enough that separate APIs are warranted: in particular, that an installed application or a bookmark may have zero, one or multiple tabs/windows, whereas, a document by definition has one tab/window, and multiple instances of documents with the same URL may have different transient local state which authors may wish to expose as a badge. That being the case, I think the two APIs being so similar will create confusion - I'd be hard placed to remember which of `setAppBadge()` and `setClientBadge()` was going to do the thing I want. Could we have `setClientBadge()` as an API on `Document` instead, perhaps? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/387#issuecomment-605769642
Received on Monday, 30 March 2020 04:00:57 UTC