- From: Timothy Gu <notifications@github.com>
- Date: Wed, 25 Mar 2020 11:32:12 -0700
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 25 March 2020 18:32:25 UTC
@TimothyGu commented on this pull request.
> +
+ 1. If |definition| has an [=indexed property getter=], then:
+ 1. Perform [=!=] [$CreateMethodProperty$](|target|, {{@@iterator}},
+ {{%ArrayProto_values%}}).
+ 1. If |definition| has a [=value iterator=], then:
+ 1. Assert: |definition| has an [=indexed property getter=].
+ 1. Perform [=!=] [$CreateDataProperty$](|target|, "<code>entries</code>",
+ {{%ArrayProto_values%}}).
+ 1. Perform [=!=] [$CreateDataProperty$](|target|, "<code>keys</code>",
+ {{%ArrayProto_keys%}}).
+ 1. Perform [=!=] [$CreateDataProperty$](|target|, "<code>values</code>",
+ {{%ArrayProto_values%}}).
+ 1. Perform [=!=] [$CreateDataProperty$](|target|, "<code>forEach</code>",
+ {{%ArrayProto_forEach%}}).
+ 1. If |definition| has a [=pair iterator=], then:
+ 1. Define the {{@@iterator}} and <code>entries</code> methods:
I think this is good now that a big chunk has been moved out of this algorithm.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/862#discussion_r398080690
Received on Wednesday, 25 March 2020 18:32:25 UTC