Re: [heycam/webidl] BREAKING: Convert the `unrestricted` keyword into an extended attribute (#857)

TimothyGu commented on this pull request.



> @@ -5977,6 +5971,9 @@ The {{float}} type is a floating point numeric
 type that corresponds to the set of finite single-precision 32 bit
 IEEE 754 floating point numbers. [[!IEEE-754]]
 
+When defined with the [{{Unrestricted}}] [=extended attribute=], the {{float}} type
+additionally corresponds to IEEE 754 non-finite, and special "not a number" values (NaNs). [[!IEEE-754]]

IEEE 754 specifies several versions of non-finite and not-a-number values: single-precision, double-precision, etc. You should say single-precision 32-bit to be consistent with above.

> @@ -7151,8 +7124,9 @@ ECMAScript value type.
     1.  If <a abstract-op>Type</a>(|V|) is Boolean, then
         return the {{boolean}} value that represents the same truth value.
     1.  If <a abstract-op>Type</a>(|V|) is Number, then
-        return the result of <a href="#es-to-unrestricted-double">converting</a> |V|
-        to an {{unrestricted double}}.
+        return the result of <a href="#es-to-double">converting</a> |V|
+        to an {{double}} [=extended attribute associated with|associated with=]

"a" double, not "an" double.

Also, _extended attributes_ are associated with _types_: not vice versa, as you have here. You should say "double with an [associated](https://heycam.github.io/webidl/#idl-type-extended-attribute-associated-with) [Unrestricted] extended attribute." I realize that unfortunately what you have is the norm in the spec right now, but doesn't hurt to be correct when we get a chance to.

> +
+    In the following [=IDL fragment=],
+    two [=operations=] are declared that
+    take three {{double}} arguments; one uses
+    the [{{Unrestricted}}] [=extended attribute=]
+    on all three arguments, while the other does not:
+
+    <pre highlight="webidl">
+        [Exposed=Window]
+        interface GraphicsContext {
+          void setColorFloat(double red, double green, double blue);
+          void setColorUnrestrictedFloat([Unrestricted] double red, [Unrestricted] double green, [Unrestricted] double blue);
+        };
+    </pre>
+
+    In an ECMAScript implementation of the IDL, a call to setColor3f with

What's `setColor3f`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/857#pullrequestreview-379027555