- From: ExE Boss <notifications@github.com>
- Date: Tue, 17 Mar 2020 08:05:36 -0700
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <heycam/webidl/pull/856@github.com>
Since there was support for <https://github.com/heycam/webidl/issues/843>, I decided to go ahead with opening a PR for this.
I decided to go with `i*` for signed integers because it’s what browser engines and the **Rust** programming language use and due to **ECMAScript** providing implicit support for 32‑bit signed integers using the binary **OR** operator, but none for unsigned integers:
```js
let numI32 = (num | 0); // Converts `num` to a 32-bit signed integer
```
**ECMAScript** `Array`s also restrict the length to a positive 32‑bit signed integer.
---
Resolves #843
<!--
This comment and the below content is programatically generated.
You may add a comma-separated list of anchors you'd like a
direct link to below (e.g. #idl-serializers, #idl-sequence):
Don't remove this comment or modify anything below this line.
If you don't want a preview generated for this pull request,
just replace the whole of this comment's content by "no preview"
and remove what's below.
-->
***
### :boom: Error: 400 Bad Request :boom: ###
[PR Preview](https://github.com/tobie/pr-preview#pr-preview) failed to build. _(Last tried on Mar 17, 2020, 3:05 PM UTC)_.
<details>
<summary>More</summary>
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
:rotating_light: [CSS Spec Preprocessor](https://api.csswg.org/bikeshed/) - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
:link: [Related URL](https://api.csswg.org/bikeshed/?url=https%3A%2F%2Fraw.githubusercontent.com%2FEB-Forks%2Fwebidl%2Fde28afc8b9a1904d17c8a880c55274fada961f7f%2Findex.bs&md-warning=not%20ready)
```
Error running preprocessor, returned code: 1.
FATAL ERROR: IDL SYNTAX ERROR LINE: 1 - skipped: "typedef (i8) byte"
✘ Did not generate, due to fatal errors
```
_If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please [file an issue](https://github.com/tobie/pr-preview/issues/new?title=Error%20not%20surfaced%20properly&body=See%20heycam/webidl%23856.)._
</details>
You can view, comment on, or merge this pull request online at:
https://github.com/heycam/webidl/pull/856
-- Commit Summary --
* feat: Rename numeric types to match Rust/WASM
-- File Changes --
M index.bs (838)
-- Patch Links --
https://github.com/heycam/webidl/pull/856.patch
https://github.com/heycam/webidl/pull/856.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/856
Received on Tuesday, 17 March 2020 15:05:52 UTC