- From: Jungkee Song <notifications@github.com>
- Date: Mon, 16 Mar 2020 17:53:46 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/ServiceWorker/pull/1506/review/375673275@github.com>
jungkees commented on this pull request. > + :: None + + 1. [=map/For each=] <var ignore=''>scope</var> → |registration| of [=scope to registration map=]: + 1. Let |scopeURL| be |registration|'s [=service worker registration/scope url=]. + 1. If |scopeURL|'s [=/origin=] is |origin|, then: + 1. Let |job| be the result of running [=Create Job=] with *unregister*, |scopeURL|, null, null, and null. + 1. Set |job|'s [=immediate unregister flag=]. + 1. Let |jobQueue| be [=scope to job queue map=][|job|'s [=job/scope url=], [=URL serializer|serialized=]]. + 1. Assert: |jobQueue| is not null. + 1. [=While=] |jobQueue| is not empty: + 1. Let |job| be the first item in |jobQueue|. + 1. Invoke [=Reject Job Promise=] with |job| and "{{AbortError}}" {{DOMException}}. + 1. [=queue/Dequeue=] from |jobQueue|. + 1. Invoke [=Schedule Job=] with |job|. + 1. Wait until |job|'s [=job promise=] settles. + 1. If |unclaim| is true, then: I thought deleting registration and maintaining controller as two separate primitives, but agree to your point that it wouldn't be useful to keep the controller which is in "redundant" state. I moved unclaim steps into Unregister that unconditionally runs when the immediate unregister flag is set. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1506#discussion_r393388237
Received on Tuesday, 17 March 2020 00:53:58 UTC