- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 12 Mar 2020 12:37:15 -0700
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <heycam/webidl/pull/840/review/373846359@github.com>
domenic commented on this pull request. > + 1. If |descriptor|.\[[Value]] is present, then return the result of + [=observable array exotic object/setting the length=] given |handler| and + |descriptor|.\[[Value]]. + 1. Return <emu-val>true</emu-val>. + 1. If |P| [=is an array index=], then: + 1. If [=!=] [$IsAccessorDescriptor$](|descriptor|) is <emu-val>true</emu-val>, then return + <emu-val>false</emu-val>. + 1. If |descriptor|.\[[Configurable]] is present and has the value <emu-val>false</emu-val>, + then return <emu-val>false</emu-val>. + 1. If |descriptor|.\[[Enumerable]] is present and has the value <emu-val>false</emu-val>, + then return <emu-val>false</emu-val>. + 1. If |descriptor|.\[[Writable]] is present and has the value <emu-val>false</emu-val>, + then return <emu-val>false</emu-val>. + 1. If |descriptor|.\[[Value]] is present, then return the result of + [=observable array exotic object/setting the indexed value=] given |handler|, |P|, and + |descriptor|.\[[Value]]. Hmm. This follows https://tc39.es/ecma262/#sec-integer-indexed-exotic-objects-defineownproperty-p-desc but does it incorrectly. There an absent value field will return true without doing anything. I'll update this to follow that behavior. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/840#discussion_r391847843
Received on Thursday, 12 March 2020 19:37:27 UTC