Re: [heycam/webidl] Meta: use Makefile from deploy.sh (#850)

Ms2ger commented on this pull request.



> @@ -28,6 +29,11 @@ else
   exit 22 \
  );
 endif
+ifdef node_installed
+ node ./check-grammar.js index.html
+else
+ @echo You need node for grammer checking.

One comment, though... Do we want this to not happen silently in automation if something's off with the setup, or should it fail loudly?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/850#pullrequestreview-372672789

Received on Wednesday, 11 March 2020 11:24:44 UTC