Re: [whatwg/fetch] HTTP cache partitioning (#943)

domenic commented on this pull request.

This looks great to me editorially, and to the extent of my understanding of the fetch algorithms. We again will need @annevk for final signoff, both because he's the editor, and because I am not 100% confident in my domain knowledge here for checking the semantics.

But yeah, @annevk, I think this and the dependent https://github.com/whatwg/html/pull/4966 are now in pretty solid shape, and your review would be appreciated.

> +steps:
+
+<ol>
+ <li>
+  <p>Let <var>environmentSettings</var> be <var>request</var>'s <a for=request>client</a>.</p></li>
+
+ <li>
+  <p>If <var>environmentSettings</var> is null, then return null.</p></li>
+
+ <li>
+  <p>Let <var>topLevelOrigin</var> be <var>environmentSettings</var>'s top-level origin and
+  <var>origin</var> be its <a for="environment settings object">origin</a>.</p></li>
+
+ <li>
+  <p>Let <var>topLevelOriginAgentClusterKey</var> be the result of
+  <a href="https://html.spec.whatwg.org/#obtain-agent-cluster-key">obtaining an agent cluster key</a>,

These should also be updated to `<a>obtaining an agent cluster key</a>`, but will need HTML-side updates before that correctly auto-links. No action for now but something to keep in mind before the editors do the full merge.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/943#pullrequestreview-368270625