- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 24 Jun 2020 21:12:51 +0000 (UTC)
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/streams/pull/1047@github.com>
This series of commits (meant to be squashed, but separated out for easier reviewing) moves the spec from using ES-262 [records](https://tc39.es/ecma262/#sec-list-and-record-specification-type) to Infra [structs](https://infra.spec.whatwg.org/#struct). The main advantage here is that it lets us define the structs and their items in more detail, so that the reader has a better chance of knowing what they mean. Additionally, we can easily cross-link to the item definitions from their usage sites. It also has the minor advantage of moving us more toward other web specifications, and reducing the problem posed by #825. In the process I made the following editorial changes that went beyond fancy search-and-replace. (These are the ones that show up as changed in the reference implementation.) - Instead of representing a writable stream's internal queue as containing chunks that were either the string "close" or a Record{ [[chunk]]: _jsValue_ }}, I created a "special close value" which can be put alongside the chunks directly. - I renamed one of the items for "pending pull-into descriptors" from "ctor" to "view constructor". --- I'd mildly prefer to merge this before continuing work on #1045, since per the latest thinking there we'll bundle the chunkSteps/doneSteps/errorSteps into a struct, and it'd be good to stay consistent. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/1047 -- Commit Summary -- * Pending abort request * Special close value * Queue with sizes * pull-into descriptors * Readable byte stream queue entries -- File Changes -- M index.bs (272) M reference-implementation/lib/ReadableByteStreamController-impl.js (2) M reference-implementation/lib/abstract-ops/readable-streams.js (4) M reference-implementation/lib/abstract-ops/writable-streams.js (14) -- Patch Links -- https://github.com/whatwg/streams/pull/1047.patch https://github.com/whatwg/streams/pull/1047.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1047
Received on Wednesday, 24 June 2020 21:13:05 UTC