- From: Marcos Cáceres <notifications@github.com>
- Date: Tue, 23 Jun 2020 15:53:58 -0700
- To: w3c/pointerlock <pointerlock@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 23 June 2020 22:54:11 UTC
@marcoscaceres commented on this pull request. > @@ -160,12 +160,12 @@ <h2> <dd> An event generated by the user agent as a result of user interaction processed by the user agent to interact with the page. e.g. - <code>click</code>, but not <code>mousemove</code>. Engagement - gestures are any events included in the definition of being - <a>triggered by user activation</a> with the addition of - <code>keypress</code> and <code>keyup</code>. Note that operating - system level accessibility and internationalization features may - intercept gestures before the user agent processes them for + <code>click</code>, but not <code>mousemove</code>. Engagement + gestures are defined by the events in the list of <a>activation This is good, but I was expecting this also to be part of `.requestPointerLock()` too... that is, a `NotAllowedError` should be thrown when this check happens. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/pointerlock/pull/65#pullrequestreview-436213881
Received on Tuesday, 23 June 2020 22:54:11 UTC