- From: Mattias Buelens <notifications@github.com>
- Date: Tue, 23 Jun 2020 14:03:59 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 23 June 2020 21:04:12 UTC
Looks good to me! 👍 I especially like the separation between `chunkSteps` and `doneSteps`. I find [the new version](https://github.com/whatwg/streams/blob/6f6a064ec51865d0f7119169a353c2c3b3c00e1b/reference-implementation/lib/ReadableStream-impl.js#L131-L135) of `asyncIteratorNext` to be much more understandable than [the old one](https://github.com/whatwg/streams/blob/c20f174396617787e1176e11796fc5039088a5ab/reference-implementation/lib/ReadableStream-impl.js#L131-L144). Perhaps we could use a ["struct"](https://infra.spec.whatwg.org/#structs) or a ["tuple"](https://infra.spec.whatwg.org/#tuple) in the spec text to represent all three steps, so we can thread them as a single argument through the various operations? Or would that make the reference implementation too different from the spec text? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1045#issuecomment-648421434
Received on Tuesday, 23 June 2020 21:04:12 UTC