- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 22 Jun 2020 09:32:07 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 22 June 2020 16:32:19 UTC
Ah, this is excellent; thank you so much for working on this! For (1), my concern is that `wpt-runner` currently uses its own copies of testharness.js and testdriver-dummy.js. Indeed, that does require rolling the submodule, which is annoying, but I think we should stay consistent. So I would suggest for now that we continue to use the submodule's copy, but I am also open to the idea of revving wpt-runner to no longer use the submodule and instead require a "path to WPT root" where it can pull the files from. (That also might be a good time to change the path configuration in general; I'm not so happy about the "mount a subpath" behavior.) For (2), I agree a fake fetch is the way to go, in pretty much exactly the way you've outlined. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/issues/1044#issuecomment-647632419
Received on Monday, 22 June 2020 16:32:19 UTC