Re: [whatwg/streams] Always resolve tee's cancel promise after stream closes or errors (#1039)

@domenic commented on this pull request.



> @@ -2089,6 +2090,7 @@ create them does not matter.
      |r|).
   1. Perform ! [$ReadableStreamDefaultControllerError$](|branch2|.\[[readableStreamController]],
      |r|).
+  1. [=Resolve=] |cancelPromise| with undefined.

> So I think resolving the cancel promise should be acceptable...?

I agree. It seems good to be symmetric with

> For a regular stream, when you call controller.error(e) while canceling, the error does not affect the promise returned by cancel() in any way.

Separately, we may indeed want to revisit that, but keeping them symmetric for now makes sense.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1039#discussion_r440312734