- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 12 Jun 2020 12:18:16 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 12 June 2020 19:18:28 UTC
@domenic approved this pull request. LGTM with one thing I don't quite understand, but trust you all on enough to still give the green checkmark. > + <li><p>Let <var>topLevelOrigin</var> be null. + + <li> + <p>If <var>request</var>'s <a for=request>reserved client</a> is non-null, then: + + <ol> + <li><p>Set <var>topLevelOrigin</var> to <var>request</var>'s <a for=request>reserved client</a>'s + <a for="environment">top-level origin</a>. + + <li> + <p>If <var>topLevelOrigin</var> is null, then set <var>topLevelOrigin</var> to + <var>request</var>'s <a for=request>reserved client</a>'s + <a for="environment">top-level creation URL</a>'s <a for=url>origin</a>. + + <p class=note>This happens for top-level navigations only. + </ol> Can you remind me why we're doing this here, instead of having HTML ensure top-level origin is always non-null by setting it to the origin of the top-level creation URL? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/943#pullrequestreview-429981659
Received on Friday, 12 June 2020 19:18:28 UTC