- From: Timothy Gu <notifications@github.com>
- Date: Wed, 10 Jun 2020 11:28:32 -0700
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 10 June 2020 18:28:44 UTC
@TimothyGu approved this pull request. LGTM other than the one tiny thing. > + 1. Let |result| be [$CreateIterResultObject$](<emu-val>undefined</emu-val>, + <emu-val>true</emu-val>). The webidl2js implementation uses _value_ as the first parameter rather than **undefined**, I believe correctly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/891#pullrequestreview-428321395
Received on Wednesday, 10 June 2020 18:28:44 UTC